This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix issue #206 #207
Merged
Fix issue #206 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth tag len for AES-CBC+HMAC algorithms should match the key size, see RFC 7518 Section 5.2.4 and Section 5.2.5. Unfortunately this will (as-is) cause problems with decrypting AES-CBC+HMAC ciphertexts that were encrypted with this library that used 192-bit and 256-bit key sizes. A future pull request could add a flag to add some sort of compabitility flag to allow for decryption to continue working for those cases.
mbyczkowski
reviewed
Nov 21, 2018
mbyczkowski
approved these changes
Nov 21, 2018
alokmenghrajani
approved these changes
Nov 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth tag len for AES-CBC+HMAC algorithms should match the key size, see RFC 7518 Section 5.2.4 and Section 5.2.5. Unfortunately this will (as-is) cause problems with decrypting AES-CBC+HMAC ciphertexts that were encrypted with this library that used 192-bit and 256-bit key sizes. Maybe we could address that with a special transitionary flag that allow for backwards compatibility? Or just note that data needs to be re-encrypted before upgrading in the release notes?