This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add checks for octet length of X, Y, and D #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
csstaub
approved these changes
Dec 5, 2018
|
This looks good to me. Thank you @jsha! |
|
(I'll release this in a v2.2.1 later today) |
jsha
added a commit
to jsha/go-jose
that referenced
this pull request
Jun 26, 2019
In square#210 I introduced some error messages for incorrect octet string length for X and Y. The error message for the public key case incorrectly stated that it was for a private key.
csstaub
pushed a commit
that referenced
this pull request
Oct 22, 2019
In #210 I introduced some error messages for incorrect octet string length for X and Y. The error message for the public key case incorrectly stated that it was for a private key.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWK spec says these fields in EC keys MUST be a fixed length, but go-jose wasn't
checking their length on input. I got a report from the Let's Encrypt forums that this
caused some confusion with certain software that was generating invalid JWKs. Boulder
(using go-jose) ingested those keys just fine, but output a different (valid) encoding.
This change enforces the correct length on parsing. It also changes some
t.Errorftot.Fatalfthat I noticed during testing. Thet.Fatalfchecks are for failures that preventthe test from meaningfully continuing.