This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Export RandReader for deterministic testing #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
(re: CLA, I believe my employer has reached out to Square.) |
|
Change looks good to me. If you need help contacting the right person about setting up the CLA just shoot me an email, I’m cs(at)squareup.com. |
csstaub
approved these changes
Dec 20, 2018
|
Merged, thanks for the contribution @jack-stripe! If you need me to tag this in a release let me know. |
|
Thanks @csstaub! If you have the chance to tag a release with this that would be great. And thanks again for an excellent library. |
|
This is out, in release v2.2.2: https://github.com/square/go-jose/releases/tag/v2.2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We're using go-jose for a new project, and it'd be quite useful to be able to stub its randomness in tests. The specific kind of test we want to enable is where a partner gives us known inputs to be JWE'd and outputs to compare the results to (which gives us a way of asserting that we're actually invoking
go-josecorrectly.)This should be a fully backwards-compatible change, but let me know what you think!