This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
jwt.ValidateWithLeeway: Return error if IssuedAt (iat) is in the future #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to ValidateWithLeeway that the IssuedAt (iat) field is in the past. This field is optional, and this check is not required by the RFC, but seems like a reasonable check. See: https://tools.ietf.org/html/rfc7519#section-4.1.6 Fixes #216
|
|
csstaub
approved these changes
Feb 4, 2019
|
Thanks @evanj! I'll let this sit for a bit and then make a release with the change. |
evanj
added a commit
to evanj/googlesignin
that referenced
this pull request
Feb 4, 2019
... or it will when the next version of the library is released. See: square/go-jose#217
evanj
pushed a commit
to evanj/googlesignin
that referenced
this pull request
Feb 4, 2019
... or it will when the next version of the library is released. See: square/go-jose#217
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to ValidateWithLeeway that the IssuedAt (iat) field is in the
past. This field is optional, and this check is not required by the RFC,
but seems like a reasonable check. See:
https://tools.ietf.org/html/rfc7519#section-4.1.6
Fixes #216