This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Reverse bytes in Ed25519 keys. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang golang.org/x/crypto/ed25519 package uses 64 bytes to store the public and private parts of the key, the first 32 bytes correspond to the private part, and the last 32 to the public part. See: https://github.com/golang/crypto/blob/master/ed25519/ed25519.go#L90 go-jose implementation reverses the bytes causing that the JSON version of the private key has the private part in the 'x' property and the public in the 'd', and it should be the other way arround, see: https://tools.ietf.org/html/rfc8037#appendix-A.1
maraino
added a commit
to smallstep/certificates
that referenced
this pull request
Apr 5, 2019
This is a dependency for smallstep/cli#105, it will be solved once square/go-jose#224 gets merged
maraino
added a commit
to smallstep/cli
that referenced
this pull request
Apr 5, 2019
This is a dependency for #105, it will be solved once square/go-jose#224 gets merged
This was referenced Apr 5, 2019
|
Wow, that's a really good catch, thanks @maraino. |
csstaub
approved these changes
Apr 10, 2019
|
Thanks @csstaub, can you tag a new release? |
|
@maraino Already on it! |
|
Released in v2.3.1: https://github.com/square/go-jose/releases/tag/v2.3.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang golang.org/x/crypto/ed25519 package uses 64 bytes to store
the public and private parts of the key, the first 32 bytes correspond
to the private part and the last 32 to the public part. See:
https://github.com/golang/crypto/blob/master/ed25519/ed25519.go#L90
go-jose implementation reverses the bytes causing that the JSON version
of the private key has the private part in the 'x' property and the
public in the 'd', and it should be the other way around, see:
https://tools.ietf.org/html/rfc8037#appendix-A.1