Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Support RFC 7638 canonical kid for JWK #269

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Conversation

zamicol
Copy link
Contributor

@zamicol zamicol commented Nov 11, 2019

Support RFC 7638 canonical kid for JWK

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2019

CLA assistant check
All committers have signed the CLA.

@zamicol zamicol changed the title Issue #268 Support RFC 7638 canonical kid for JWK Nov 11, 2019
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
jwk.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@csstaub csstaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @zamicol. Left a small comment but otherwise LGTM.

jose-util/generate.go Outdated Show resolved Hide resolved
@zamicol
Copy link
Contributor Author

zamicol commented Nov 14, 2019

I fixed that issue. If it looks good I think this is ready for merging.

@mbyczkowski mbyczkowski merged commit 75a4b70 into square:master Nov 19, 2019
mbyczkowski added a commit that referenced this pull request Mar 8, 2020
* Support RFC 7638 Thumbprints; fix privKey and pubKey mix up

Cherry-picked from #269

Since jwk-keygen/main.go was moved to jose-util/generate.go on master,
this required the patch to be applied manually.

Co-authored-by: Zach Collier <[email protected]>
mbyczkowski added a commit that referenced this pull request Mar 8, 2020
* Support RFC 7638 Thumbprints; fix privKey and pubKey mix up

Cherry-picked from #269

Since jwk-keygen/main.go was moved to jose-util/generate.go on master,
this required the patch to be applied manually.

Co-authored-by: Zach Collier <[email protected]>
@mbyczkowski mbyczkowski mentioned this pull request Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants