This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
Support RFC 7638 canonical kid for JWK #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oogle/uuid dependency
golangcibot
reviewed
Nov 12, 2019
csstaub
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @zamicol. Left a small comment but otherwise LGTM.
I fixed that issue. If it looks good I think this is ready for merging. |
mbyczkowski
added a commit
that referenced
this pull request
Mar 8, 2020
* Support RFC 7638 Thumbprints; fix privKey and pubKey mix up Cherry-picked from #269 Since jwk-keygen/main.go was moved to jose-util/generate.go on master, this required the patch to be applied manually. Co-authored-by: Zach Collier <[email protected]>
mbyczkowski
added a commit
that referenced
this pull request
Mar 8, 2020
* Support RFC 7638 Thumbprints; fix privKey and pubKey mix up Cherry-picked from #269 Since jwk-keygen/main.go was moved to jose-util/generate.go on master, this required the patch to be applied manually. Co-authored-by: Zach Collier <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support RFC 7638 canonical kid for JWK