Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyScaleDown() compatibility with fit() #1623

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

magneticflux-
Copy link

@magneticflux- magneticflux- commented May 11, 2017

Resolves #941

This pull request adds a boolean flag that is used to identify if calling onlyScaleDown was requested. When the fit() call resizes the request, the doOnlyScaleDown boolean flag is checked and the onlyScaleDown method may be called.

I also performed minor changes in the test file that I modified, namely adding error suppression for obviously intentional lines of code.

I have accepted the Square CLA.

@magneticflux-
Copy link
Author

@JakeWharton Friendly ping! 😃

@Diegitsen
Copy link

p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants