Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A base LRU cache that allows you to store EXIF data with the Bitmap. #2014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

extorn
Copy link

@extorn extorn commented Oct 6, 2018

A base LRU cache that allows you to store EXIF data (or whatever else you want) alongside the bitmap.

@PaulWoitaschek
Copy link

How is this related to Picasso? Where are the tests? And most important: Where did the file extension go?

@extorn
Copy link
Author

extorn commented Nov 24, 2018

You may use the code as you wish. There are no tests else I'd have supplied them.
I didn't really think you'd have interest in this else it would have been done already. That said I maintain a cache of image metadata linked to an image in this way to for example to avoid having to rescan the image. The purpose of the PR was to raise a suggestion with example rather than as something that could be committed.

I have a custom downloader, that downloads images from an http URI. This Downloader extracts the image metadata before creating an instance of DownloaderResponse. In fact, I note that I've since extended this class to provide an EXIF rotational degrees flag. This all happens because once its been converted into a Bitmap, its just a bitmap without EXIF or IPTC data. If this new code is also of interest you are welcome to it, but it really isn't that relevant to Picasso as its using a non Picasso http client.

@NightlyNexus
Copy link
Contributor

Hey, thanks for the code. Also, feel free to open issues with feature requests, too.

We don't have the Cache interface anymore. I think you can achieve this independently of Picasso by keeping your own metadata cache around. Is there anything Picasso needs to do to support your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants