Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keyless #1659

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: keyless #1659

wants to merge 7 commits into from

Conversation

phbelitz
Copy link
Member

@phbelitz phbelitz commented Jun 14, 2024 •
edited
Loading

Adds support for keyless cosign verification. This feature allows users to verify images signed with cosign without the need for a public key.

fixes #1493

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

@phbelitz
Copy link
Member Author

phbelitz commented Jun 14, 2024 •
edited
Loading

Integration tests and documentation are still missing and values.yaml needs to be reverted ...

Starkteetje
Starkteetje reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@Starkteetje Starkteetje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the mental capacity today to review this fully, but here are some preliminary comments

charts/connaisseur/values.yaml Outdated Show resolved Hide resolved
internal/utils/validation.go Outdated Show resolved Hide resolved
internal/validator/auth/trust_root.go Outdated Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
internal/validator/cosignvalidator/cosign_validator.go Outdated Show resolved Hide resolved
internal/validator/cosignvalidator/cosign_validator.go Outdated Show resolved Hide resolved
internal/validator/cosignvalidator/cosign_validator.go Outdated Show resolved Hide resolved
@phbelitz
feat: keyless
87a5d81 
Adds support for keyless cosign verification. This feature allows users to verify images signed with cosign without the need for a public key.

fixes #1493
@phbelitz
fixup! feat: keyless
0b56306
@phbelitz
fixup! feat: keyless
1041859
@phbelitz phbelitz requested a review from Starkteetje July 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starkteetje Starkteetje Awaiting requested review from Starkteetje

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phbelitz @Starkteetje