Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argon: Pox 4 #4085

Closed
wants to merge 6 commits into from
Closed

Argon: Pox 4 #4085

wants to merge 6 commits into from

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented Nov 23, 2023 •
edited
Loading

Description

This PR update pox-4 to include all required features for Argon

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (252b77f) 0.04% compared to head (8021824) 0.04%.
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #4085   +/-   ##
=======================================
  Coverage    0.04%    0.04%           
=======================================
  Files         419      419           
  Lines      297643   297643           
=======================================
  Hits          136      136           
  Misses     297507   297507

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moodmosaic moodmosaic mentioned this pull request Nov 24, 2023
Merged
5 tasks
moodmosaic and others added 2 commits November 28, 2023 11:52
@moodmosaic
fix(bns): adjust lease timings for epoch 2.4 simnet compatibility
a99cd10 
This commit addresses an issue where lease timings were not correctly
adjusted for compatibility with epoch 2.4.

The epoch 2.4 update introduced an extra block in the simnet start
sequence, causing names to expire one block later than before.

This fix ensures that lease timings align with the updated epoch
requirements.
@friedger
Merge pull request #4087 from moodmosaic/feat/pox-4-simnet-lease-timi…
8021824 
…ng-epoch-2.4

Argon: Pox 4 - Adjust Lease Timing for Epoch 2.4 Compatibility in BNS tests
@friedger
Copy link
Collaborator Author

Replaced by #4094

@friedger friedger closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@friedger @moodmosaic