Use is-in-mainnet in pox-4.clar #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
moodmosaic
reviewed
Dec 3, 2023
| [contracts.pox-4] | ||
| path = "./contracts/pox/pox-4-testnet.clar" | ||
| path = "../../stackslib/src/chainstate/stacks/boot/pox-4.clar" |
hugocaillard
approved these changes
Dec 4, 2023
friedger
merged commit 7b47c47
into
feat/pox-4-disallow-stacking-during-prepare-phase
1 check passed
jcnelson
reviewed
Dec 5, 2023
There was a problem hiding this comment.
I wish I'd had a chance to review this before it got merged, because this patch could use some improvement. Namely, the organization of the ADDRESS_VERSION constants are confusing. If you look in pox-4.clar, you'll see code comments to the effect that the four address versions here are included in a separate file, and yet here they are. Could you send another PR that cleans up pox-4.clar's ADDRESS_VERSIONs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way how pox-4 contracts for mainnet and testnet are created. Instead of string concatenation, we now use
is-in-mainnetin clarity.Applicable issues
Additional info (benefits, drawbacks, caveats)
pox_4_body is only used to create pox-4 contract for mainnet and testnet. It is not used for creating pox-4 contract with other constants.
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml