-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pox-4.clar to Clarinet.toml #4194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4194 +/- ##
==========================================
- Coverage 83.34% 83.31% -0.03%
==========================================
Files 432 432
Lines 306557 306556 -1
==========================================
- Hits 255490 255408 -82
- Misses 51067 51148 +81 ☔ View full report in Codecov by Sentry. |
wileyj
reviewed
Dec 20, 2023
setzeus
reviewed
Dec 22, 2023
jcnelson
reviewed
Jan 2, 2024
friedger
commented
Jan 9, 2024
hugocaillard
reviewed
Jan 9, 2024
setzeus
approved these changes
Jan 18, 2024
MarvinJanssen
approved these changes
Jan 19, 2024
kantai
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds pox-4.clar to Clarinet.toml so that developers can use
clarinet check
when making changes to pox-4 contract.Since Clarinet 2, the different constants for mainnet and testnet can be handled in a single file (pox-4.clar without pox-mainnet or pox-testnet) using
is-in-mainnet
.Applicable issues
No issue. Just chore for developer experience
Additional info (benefits, drawbacks, caveats)
This change was initially proposed and already reviewed in #4094.
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml