Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pox-4.clar to Clarinet.toml #4194

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Add pox-4.clar to Clarinet.toml #4194

merged 14 commits into from
Jan 23, 2024

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented Dec 19, 2023

Description

This PR adds pox-4.clar to Clarinet.toml so that developers can use clarinet check when making changes to pox-4 contract.

Since Clarinet 2, the different constants for mainnet and testnet can be handled in a single file (pox-4.clar without pox-mainnet or pox-testnet) using is-in-mainnet.

Applicable issues

No issue. Just chore for developer experience

Additional info (benefits, drawbacks, caveats)

This change was initially proposed and already reviewed in #4094.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3094df2) 83.34% compared to head (eaa8363) 83.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4194      +/-   ##
==========================================
- Coverage   83.34%   83.31%   -0.03%     
==========================================
  Files         432      432              
  Lines      306557   306556       -1     
==========================================
- Hits       255490   255408      -82     
- Misses      51067    51148      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@setzeus setzeus requested a review from kantai January 22, 2024 20:46
@kantai kantai merged commit 951becf into next Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants