Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devnet tweaks #4234

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

feat: add devnet tweaks #4234

wants to merge 2 commits into from

Conversation

hugocaillard
Copy link
Collaborator

Description

wip

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9690ecd) 59.40% compared to head (ae1fb3f) 19.77%.

Files Patch % Lines
testnet/stacks-node/src/config.rs 50.00% 5 Missing ⚠️
testnet/stacks-node/src/nakamoto_node/relayer.rs 0.00% 3 Missing ⚠️
stackslib/src/burnchains/bitcoin/indexer.rs 66.66% 1 Missing ⚠️
...-node/src/burnchains/bitcoin_regtest_controller.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4234       +/-   ##
===========================================
- Coverage   59.40%   19.77%   -39.64%     
===========================================
  Files         446      446               
  Lines      318774   318784       +10     
===========================================
- Hits       189381    63041   -126340     
- Misses     129393   255743   +126350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 4 times, most recently from 7888b13 to e09ab93 Compare January 17, 2024 17:35
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 2 times, most recently from 5b02e01 to 2d17422 Compare January 23, 2024 14:05
Dockerfile.debian Outdated Show resolved Hide resolved
@jbencin
Copy link
Contributor

jbencin commented Jan 23, 2024

Can you explain the reason for changing the constants you did in the PR description? I'm not objecting to the changes, I just don't understand them well

@hugocaillard
Copy link
Collaborator Author

Hey @jbencin
This PR is still quite drafty, I haven't self-reviewed and it's mostly code that I didn't write myself.
I'll update the description before switching to ready for review

@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 4 times, most recently from 9bfba59 to ae1fb3f Compare February 9, 2024 15:04
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 4 times, most recently from ae30032 to eba1b65 Compare March 20, 2024 14:10
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 6 times, most recently from f259cd0 to 628f35b Compare March 26, 2024 17:14
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 4 times, most recently from c7a7b47 to 465d9f0 Compare April 2, 2024 09:23
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 2 times, most recently from b699835 to 2a7f237 Compare May 2, 2024 11:09
@hugocaillard hugocaillard changed the base branch from next to master May 2, 2024 11:11
@hugocaillard hugocaillard changed the base branch from master to develop July 12, 2024 10:30
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 2 times, most recently from 6250542 to 4642d73 Compare July 25, 2024 14:36
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 3 times, most recently from 3a57358 to 06c9ea3 Compare August 1, 2024 09:03
@hugocaillard hugocaillard force-pushed the feat/devnet-tweaks branch 3 times, most recently from d2f4734 to 9628b43 Compare September 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants