Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nakamoto mempool sync #4966

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Nakamoto mempool sync #4966

merged 14 commits into from
Jul 17, 2024

Conversation

jcnelson
Copy link
Member

This makes the mempool DB and mempool sync state machines compatible with Nakamoto. To do so, we treat the mempool transaction record's height as the coinbase height, and its block_hash and consensus_hash as that of the tenure-start block.

@jcnelson jcnelson added the 3.0 label Jul 12, 2024
kantai
kantai reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just a few comments about the usage of "resolve_tenure" but will re-review when there's nakamoto-specific tests added

stackslib/src/core/tests/mod.rs Outdated Show resolved Hide resolved
stackslib/src/core/tests/mod.rs Outdated Show resolved Hide resolved
stackslib/src/core/tests/mod.rs Outdated Show resolved Hide resolved
stackslib/src/net/api/tests/postmempoolquery.rs Outdated Show resolved Hide resolved
@jcnelson jcnelson marked this pull request as ready for review July 16, 2024 20:34
@jcnelson jcnelson requested a review from a team as a code owner July 16, 2024 20:34
obycode
obycode reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just the one question about the outstanding todo.

@jcnelson jcnelson requested review from kantai and obycode July 17, 2024 14:30
@jcnelson jcnelson added this pull request to the merge queue Jul 17, 2024
Merged via the queue into develop with commit 202b45c Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

Assignees
No one assigned
Labels
3.0-Testing 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcnelson @kantai @obycode @saralab