-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nakamoto mempool sync #4966
Nakamoto mempool sync #4966
Conversation
…` as the coinbase height, and `consensus_hash` and `block_hash` as the tenure-start consensus hash and block hash
…amoto headers for the tip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just a few comments about the usage of "resolve_tenure" but will re-review when there's nakamoto-specific tests added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Just the one question about the outstanding todo.
This makes the mempool DB and mempool sync state machines compatible with Nakamoto. To do so, we treat the mempool transaction record's
height
as the coinbase height, and itsblock_hash
andconsensus_hash
as that of the tenure-start block.