-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Workflow to Build Signer Releases #4968
Conversation
The PR was marked as draft because there are still documentation changes in progress. |
Needs documentation updates for release process in the README |
my bad - my push yesterday failed because i didn't rebase first. i think for the stacks-core release docs, i'm going to make as few edits as i can so it's still correct, and address missing/changed items in a different PR so this isn't blocking upcoming deadlines. |
Bare minimum was updated - it's not entirely correct, but it's close enough to open this for review. I'll address the larger docs changes in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Left a few suggestions, but nothing important enough that should be considered blocking.
Make the required modifications in order to be able to release
stacks-node
andstacks-signer
separately.Changes:
CMD
instruction now only runs the signer if it is a signer release, otherwise the node.stacks-signer
if it is a signer release, otherwise all binaries), then publish the release.stacks-signer
docker repository if it is a signer release, otherwise to default repository (stacks-core
in this case) as well as the legacystacks-blockchain
.How is the release built now?
workflow_dispatch
event against the release branch.Release branch patterns:
release/x.x.x.x.x(-rcx)
- A node release branch, wherex
are numbers, and-rcx
is optional.release/signer-x.x.x.x.x.x(-rcx)
- A signer release branch, wherex
are numbers, and-rcx
is optional.Workflow example runs (test failures are unaffected by these changes):
master
branch ofstacks-core
): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9910596033develop
branch ofstacks-core
): https://github.com/BowTiedDevOps/stacks-core/actions/runs/9910597101Releases built by this workflow:
Docker images:
stacks-blockchain
repository: https://hub.docker.com/repository/docker/bowtieddevops/stacks-blockchain/generalstacks-core
repository: https://hub.docker.com/repository/docker/bowtieddevops/stacks-core/generalstacks-signer
repository: https://hub.docker.com/repository/docker/bowtieddevops/stacks-signer/generalApplicable issues:
stacks-signer
binary #4278