TODO's addressing #4972
TODO's addressing #4972
Conversation
clarity/src/vm/clarity_wasm.rs
Outdated
| @@ -1530,7 +1518,7 @@ fn pass_argument_to_wasm( | |||
| Ok((buffer, offset, adjusted_in_mem_offset)) | |||
| } | |||
| Value::Sequence(SequenceData::String(CharType::UTF8(_s))) => { | |||
| todo!("Value type not yet implemented: {:?}", value) | |||
| Err(Error::Wasm(WasmError::UnhandledType)) | |||
There was a problem hiding this comment.
This one should not be an error. This just needs to get implemented. Please leave the todo! and open an issue for it.
clarity/src/vm/clarity_wasm.rs
Outdated
| Value::Principal(_p) => Err(Error::Wasm(WasmError::UnhandledType)), | ||
| Value::CallableContract(_c) => Err(Error::Wasm(WasmError::UnhandledType)), | ||
| Value::Tuple(_t) => Err(Error::Wasm(WasmError::UnhandledType)), |
There was a problem hiding this comment.
Same for these, but don't worry about opening an issue for these, @Acaccia is already working on them.
clarity/src/vm/errors.rs
Outdated
| @@ -144,6 +144,7 @@ pub enum WasmError { | |||
| ExpectedReturnValue, | |||
| InvalidIndicator(i32), | |||
| Runtime(wasmtime::Error), | |||
| UnhandledType, | |||
There was a problem hiding this comment.
This error should instead be InvalidType. We don't want an error for a type that is not handled yet, just an error for a type that should not be allowed where it was found.
There was a problem hiding this comment.
Or you could use the existing InvalidNoTypeInValue and add InvalidListUnionTypeInValue.
There was a problem hiding this comment.
Done. Added InvalidListUnionTypeInValue.
clarity/src/vm/errors.rs
Outdated
| @@ -182,6 +183,7 @@ impl fmt::Display for WasmError { | |||
| write!(f, "Invalid response/optional indicator: {indicator}") | |||
| } | |||
| WasmError::Runtime(e) => write!(f, "Runtime error: {e}"), | |||
| WasmError::UnhandledType => write!(f, "Type not handled"), | |||
|
@obycode Made changes to address the errors. Now I understand your intent. Thanks! |
No description provided.