Clarity-Wasm: Implement "pass_argument_to_wasm" for remaining types #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for optional and response
obycode
reviewed
Jul 23, 2024
| @@ -539,21 +539,16 @@ pub fn call_function<'a, 'b, 'c>( | |||
|
|
|||
| // Convert the args into wasmtime values | |||
| let mut wasm_args = vec![]; | |||
| for arg in args { | |||
| for (arg, ty) in args.iter().zip(func_types.get_arg_types()) { | |||
There was a problem hiding this comment.
Can we add a check that args and func_types are the same size?
There was a problem hiding this comment.
Not sure this is useful there, the typechecker should catch the inequality before that stage.
There was a problem hiding this comment.
yeah, but aren't we going with a "don't trust the type checker" policy? Or maybe "trust but verify"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the stacks-core part of clarity-wasm's PR 443.
It implements the remaining types and fixes the current implementation that did not respect the ABI.
The tests are not ready yet in the original repo.