Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bitcoin peer and ports in example config files #4980

Closed
wants to merge 1 commit into from

Conversation

CharlieC3
Copy link
Member

Description

Updates the bitcoin peer host and ports in the example config files and anywhere they're mentioned in repo docs.
This will enable us to sunset the VMs behind the previous domains while reducing usage of old DNS records.

@CharlieC3 CharlieC3 requested a review from wileyj July 19, 2024 16:13
@CharlieC3 CharlieC3 self-assigned this Jul 19, 2024
@CharlieC3 CharlieC3 requested a review from a team as a code owner July 19, 2024 16:13
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj enabled auto-merge July 19, 2024 19:11
@wileyj wileyj added this pull request to the merge queue Jul 19, 2024
@@ -8,11 +8,11 @@ wait_time_for_microblocks = 10000
[burnchain]
chain = "bitcoin"
mode = "xenon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just noticed, I think since this is a regtest network now, this should be krypton.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obycode Does it just make sense to consolidate the testnet and regtest follower confs? The configuration behind the two are pretty much identical now if not exactly identical. The main designation now is just what the network operator chooses to call it based on how it's used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it probably does.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jul 19, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@CharlieC3
Copy link
Member Author

Closing because @wileyj is going to open a separate PR with additional changes to these files, and we'd rather get it all merged in a single PR.

@CharlieC3 CharlieC3 closed this Jul 22, 2024
@CharlieC3 CharlieC3 deleted the chore/update-bitcoin-peer branch July 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants