Assert that locations are not empty #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
force-pushed
the
non_empty_locations
branch
from
6caee37
to
4f28e09
Compare
Before that an empty locations list would raise some weird pyahocorasick error about a value not being an automaton
konstin
force-pushed
the
non_empty_locations
branch
from
4f28e09
to
ed31ce2
Compare
torfsen
suggested changes
Apr 17, 2018
geoextract/__init__.py
Outdated
|
|
||
| if not list(self._automaton.items()): | ||
| raise ValueError("You must provide locations for extraction") | ||
|
|
There was a problem hiding this comment.
I'm fine with adding this check, but it should be done at the end of NameExtractor.setup instead. At that point, no further words will be added to the automaton.
|
Thanks for your contribution, @konstin! |
|
In hindsight, I think the better approach is to simply return no matches from I've made this change in 0d184e2. |
|
Ah great, that makes it even easier to use! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that an empty locations list would raise some weird pyahocorasick error about a value not being an automaton