Merge pull request #635 from koic/lsp_diagnostic_range

Fix end position of diagnostic for LSP
standardrb · Jun 23, 2024 · de139d7 · de139d7
2 parents ad9ca9e + f0df3dd
commit de139d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/standard/lsp/routes.rb b/lib/standard/lsp/routes.rb
@@ -181,7 +181,7 @@ def diagnostic(file_uri, text)
             message: msg,
             range: {
               start: {character: loc[:start_column] - 1, line: loc[:start_line] - 1},
-              end: {character: loc[:last_column] - 1, line: loc[:last_line] - 1}
+              end: {character: loc[:last_column], line: loc[:last_line] - 1}
             },
             severity: severity,
             source: "standard"

diff --git a/test/standard/runners/lsp_test.rb b/test/standard/runners/lsp_test.rb
@@ -45,17 +45,17 @@ def test_did_open
         diagnostics: [
           {code: "Layout/ArrayAlignment",
            message: "Use one level of indentation for elements following the first line of a multi-line array.",
-           range: {start: {character: 3, line: 2}, end: {character: 3, line: 2}},
+           range: {start: {character: 3, line: 2}, end: {character: 4, line: 2}},
            severity: 3,
            source: "standard"},
           {code: "Layout/ExtraSpacing",
            message: "Unnecessary spacing detected.",
-           range: {start: {character: 4, line: 2}, end: {character: 4, line: 2}},
+           range: {start: {character: 4, line: 2}, end: {character: 5, line: 2}},
            severity: 3,
            source: "standard"},
           {code: "Layout/SpaceInsideArrayLiteralBrackets",
            message: "Do not use space inside array brackets.",
-           range: {start: {character: 4, line: 2}, end: {character: 5, line: 2}},
+           range: {start: {character: 4, line: 2}, end: {character: 6, line: 2}},
            severity: 3,
            source: "standard"}
         ],