Instantiate Object-type lint_roller plugins correctly #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By supplying a path and calling Config.create, plugins that publish an :object type rules config will correctly merge in AllCops settings, such that everything seems to work. Fixes: standardrb/standard-rails#4 This breaks a lot of tests and emits a lot of warnings, so we still have to work through those
The reason this covers the problem is that it demonstrates the base configuration is still intact even though an object-type lint_roller plugin is also active.
This still emits a bunch of warnings, which sucks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were instantiating configuration objects from plugins using
RuboCop::Config.newinstead ofRuboCop::Config.create, which ended up causing subtle differences in howAllCopswas being handled when merging plugins. Namely, it resulted in the inclusion of any such plugin as disabling all previously-defined cops, which is not what we'd want. (Including a single empty object plugin in your config will effectively disable every built-in cop, which isn't super good).It still feels like there's more underlying trouble here around
AllCopsoptionDisabledByDefaultwhich was added in 1.28.0, but this will fix the immediate and urgent issue.Fixes standardrb/standard-rails#4