Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert right paren after cursor when completing funciton/method calls #5935

Open
mkaput opened this issue Jul 2, 2024 · 3 comments · May be fixed by #5956
Open

Insert right paren after cursor when completing funciton/method calls #5935

mkaput opened this issue Jul 2, 2024 · 3 comments · May be fixed by #5956
Labels
good first issue Good for newcomers help wanted Extra attention is needed ide This issue refers to CairoLS or editor extensions

Comments

@mkaput
Copy link
Contributor

mkaput commented Jul 2, 2024

Currently, LS is completing functions/methods like this:

// before
x.<caret>

// after
x.foo(<caret>

Change this to work as following:

// before
x.<caret>

// after
x.foo(<caret>)

Code to update:

cairo/crates/cairo-lang-language-server/src/ide/completion/completions.rs

Line 285 in cdaceb9

insert_text: Some(format!("{}(", name)),

@mkaput mkaput added good first issue Good for newcomers help wanted Extra attention is needed ide This issue refers to CairoLS or editor extensions labels Jul 2, 2024
PavitraAgarwal21 added a commit to PavitraAgarwal21/cairo that referenced this issue Jul 4, 2024
@PavitraAgarwal21
Insert right paren after cursor when completing method calls starkwar…
aa2cb6b 
…e-libs#5935
@mkaput mkaput linked a pull request Jul 4, 2024 that will close this issue
Insert right paren after cursor when completing method calls #5935 #5956
Open
@kaksv
Copy link

kaksv commented Jul 4, 2024

Is this issue still open?

@mkaput
Copy link
Contributor Author

mkaput commented Jul 4, 2024

There is #5956 in review that attempts to implement this

@kaksv
Copy link

kaksv commented Jul 5, 2024

Alright i had created a PR but let me look into something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed ide This issue refers to CairoLS or editor extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Insert right paren after cursor when completing method calls #5935 PavitraAgarwal21/cairo
2 participants
@mkaput @kaksv