Tests

stckme · Jul 25, 2024 · 6badce8 · 6badce8
1 parent 28f24f8
commit 6badce8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/fastapi_tests/test_rest.py b/fastapi_tests/test_rest.py
@@ -4,6 +4,7 @@
 import pytest
 import requests
 from converge import settings
+from requests.exceptions import HTTPError
 
 import apphelpers.sessions as sessionslib
 from apphelpers.db.piccolo import destroy_db_from_basetable, setup_db_from_basetable
@@ -368,10 +369,18 @@ async def worst_endpoint(foo):
         asyncio.run(wrapped_worst_endpoint(1))
     assert mocked_honeybadger.notify.call_count == 2
 
-    mocked_honeybadger.notify.side_effect = requests.exceptions.HTTPError(
+    mocked_honeybadger.notify.side_effect = HTTPError(
         response=mock.MagicMock(status_code=403)
     )
-    with pytest.raises(RuntimeError) as e:
+    with pytest.raises(RuntimeError):
         asyncio.run(wrapped_worst_endpoint(1))
-        assert "HttpError" in str(e)
+    # TODO: How to check nested exception?
     assert mocked_honeybadger.notify.call_count == 3
+
+    mocked_honeybadger.notify.side_effect = HTTPError(
+        response=mock.MagicMock(status_code=401)
+    )
+    with pytest.raises(HTTPError):
+        asyncio.run(wrapped_worst_endpoint(1))
+    # TODO: How to check nested exception?
+    assert mocked_honeybadger.notify.call_count == 4
diff --git a/tests/test_rest.py b/tests/test_rest.py
@@ -5,6 +5,8 @@
 import pytest
 import requests
 from converge import settings
+from exceptiongroup import ExceptionGroup
+from requests.exceptions import HTTPError
 
 import apphelpers.sessions as sessionslib
 from apphelpers.errors.hug import BaseError
@@ -365,10 +367,18 @@ def worst_endpoint(foo):
         wrapped_worst_endpoint(1)
     assert mocked_honeybadger.notify.call_count == 2
 
-    mocked_honeybadger.notify.side_effect = requests.exceptions.HTTPError(
+    mocked_honeybadger.notify.side_effect = HTTPError(
         response=mock.MagicMock(status_code=403)
     )
-    with pytest.raises(RuntimeError) as e:
+    with pytest.raises(RuntimeError):
         wrapped_worst_endpoint(1)
-        assert "HttpError" in str(e)
+    # TODO: How to check nested exception?
     assert mocked_honeybadger.notify.call_count == 3
+
+    mocked_honeybadger.notify.side_effect = HTTPError(
+        response=mock.MagicMock(status_code=401)
+    )
+    with pytest.raises(HTTPError):
+        wrapped_worst_endpoint(1)
+    # TODO: How to check nested exception?
+    assert mocked_honeybadger.notify.call_count == 4