Add piccolo db #104
Merged
Add piccolo db #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanarijit
force-pushed
the
add-piccolo
branch
2 times, most recently
from
d9bda0b
to
1e0d16e
Compare
Also use FastAPI dependency for async db transaction.
sayanarijit
force-pushed
the
add-piccolo
branch
from
1e0d16e
to
a88cb39
Compare
sayanarijit
commented
Feb 14, 2024
apphelpers/db/piccolo.py
Outdated
Comment on lines
27
to
36
| def dbtransaction(engine: Optional[PostgresEngine] = None, allow_nested=True): | ||
| def wrapper(f): | ||
| @wraps(f) | ||
| async def f_wrapped(*args, **kw): | ||
| async with dbtransaction_ctx(engine, allow_nested=allow_nested): | ||
| return await f(*args, **kw) | ||
|
|
||
| return f_wrapped | ||
|
|
||
| return wrapper |
There was a problem hiding this comment.
We won't be using it in FastAPI. This is only for hug compatibility (and apphelpers tests).
sayanarijit
commented
Feb 14, 2024
| result = f(*args, **kw) | ||
| return result | ||
| with dbtransaction_ctx(db): | ||
| return f(*args, **kw) |
There was a problem hiding this comment.
We won't be using it in FastAPI. This is only for hug compatibility (and apphelpers tests).
gauravr
approved these changes
Mar 6, 2024
added 2 commits
March 6, 2024 15:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use FastAPI dependency for async db transaction.