Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Value conformance for Foundation NSURL #1110

Closed
wants to merge 2 commits into from
Closed

Add a Value conformance for Foundation NSURL #1110

wants to merge 2 commits into from

Conversation

elihwyma
Copy link
Contributor

@elihwyma elihwyma commented Feb 6, 2022

No description provided.

@jberkel
Copy link
Collaborator

jberkel commented Feb 10, 2022

@elihwyma thanks for submitting a PR, there's a small lint failure in the build

@jberkel
Copy link
Collaborator

jberkel commented Feb 21, 2022

Thanks, can you merge in the current mainline with your branch? The build fails now because the underlying CI image has changed.

@elihwyma
Copy link
Contributor Author

There is only one branch to merge into

@jberkel
Copy link
Collaborator

jberkel commented Feb 28, 2022

No, I meant to update from the base branch.

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch

@jberkel jberkel mentioned this pull request Jul 16, 2022
Merged
@jberkel
Copy link
Collaborator

jberkel commented Jul 16, 2022

replaced w/ #1141

@jberkel jberkel closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elihwyma @jberkel