add decoding for UUID #1137
add decoding for UUID #1137
Conversation
|
lint should pass now |
|
Thanks for your contribution. Can you add some tests? |
|
Added a UUID field to I copy pasted apple's example UUID from foundation docs for the tests. May want to make it a constant instead. Let me know what you think! |
Sources/SQLite/Typed/Coding.swift
Outdated
| } | ||
|
|
There was a problem hiding this comment.
As the number of branches get bigger, it might be better to use a switch statement here:
switch type {
case is Data.Type:
...
The same actually for encode:
func encode<T>(_ value: T, forKey key: Key) throws where T: Swift.Encodable {
switch value {
case let data as Data:
...
| builder.column(Expression<String?>("optional")) | ||
| builder.column(Expression<Data>("sub")) | ||
| }) | ||
|
|
||
| let value1 = TestCodable(int: 1, string: "2", bool: true, float: 3, double: 4, | ||
| date: Date(timeIntervalSince1970: 0), optional: nil, sub: nil) | ||
| date: Date(timeIntervalSince1970: 0), uuid: UUID(uuidString: "E621E1F8-C36C-495A-93FC-0C247A3E6E5F")!, optional: nil, sub: nil) |
There was a problem hiding this comment.
should be defined once in a variable
There was a problem hiding this comment.
added to TestHelpers
|
Thanks Jan. Made the changes, tests passing. I put the uuid constant in |
|
Ok, looking good, just a few lint fixes left. |
|
Tried splitting the lines that were too long into two lines, but that made the test fail. So I disabled the rule at those spots. |
Tests/SQLiteTests/QueryTests.swift
Outdated
| """.replacingOccurrences(of: "\n", with: ""), | ||
| insert | ||
| ) | ||
| // swiftlint:enable line_length |
There was a problem hiding this comment.
you shouldn't need the swiftlint statements here. when you break the string, ensure that there's a single space at the beginning of the row, and no whitespace at the end of each row:
assertSQL(
"""
INSERT INTO \"emails\" (\"int\", \"string\", \"bool\", \"float\", \"double\", \"date\", \"uuid\", \"optional\",
\"sub\") VALUES (1, '2', 1, 3.0, 4.0, '1970-01-01T00:00:00.000', 'E621E1F8-C36C-495A-93FC-0C247A3E6E5F',
'optional', '\(encodedJSONString)')
""".replacingOccurrences(of: "\n", with: ""),Note the single space (relative to the string start marker """) before \"sub\" and 'optional'
| return uuid as! T | ||
| default: | ||
| // swiftlint:enable force_cast | ||
| guard let JSONString = try row.get(Expression<String?>(key.stringValue)) else { |
There was a problem hiding this comment.
variables should be lowercase actually, not even your changes, ignore
I stumbled upon issue #1126 while trying to decode a UUID using codable. As described there, encoding worked fine but decoding treated the field like json.
Added an
elseto cover the UUID case, matching theencodemethod functionality.