Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ATTACH/DETACH (#30) #1142

Merged
merged 9 commits into from
Jul 18, 2022
Merged

Add support for ATTACH/DETACH (#30) #1142

merged 9 commits into from
Jul 18, 2022

Conversation

jberkel
Copy link
Collaborator

@jberkel jberkel commented Jul 17, 2022

See #30

@jberkel
Copy link
Collaborator Author

jberkel commented Jul 17, 2022

@nathanfallet have a look if you want. I'm planning to do a release at some point later this week.

nathanfallet
nathanfallet approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@nathanfallet nathanfallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes in this PR. ATTACH and DETACH tests are working. LGTM 👍

@nathanfallet nathanfallet merged commit f21ff7d into master Jul 18, 2022
@nathanfallet nathanfallet deleted the attach-detach branch July 18, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfallet nathanfallet nathanfallet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jberkel @nathanfallet