Adds support for returning extended error codes #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows developers to diagnose and debug difficult SQLite issues in a backwards compatible fashion by using
sqlite3_extended_errcode()to return more detailed "extended error codes". See https://sqlite.org/rescode.html#primary_result_codes_versus_extended_result_codes for more info. There is no current mechanism to enable this.In particular, at dropbox we have seen
SQLITE_IOERRquite a bit in production and expect that the extended error code will give us more detailed diagnosis (likeSQLITE_IOERR_VNODEreferenced in #630 and by apple https://devstreaming-cdn.apple.com/videos/wwdc/2016/242vdhuk4hmwrxnb465/242/242_whats_new_in_core_data.pdf)