Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ithe IndexDefinition properties public #1196

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Make ithe IndexDefinition properties public #1196

merged 1 commit into from
Apr 8, 2023

Conversation

stefansaasen
Copy link
Contributor

The documentation suggests that the index schema information can be queried. That requires the IndexDefinition properties to be public.

At the moment, the following code does not work, when used in an project that depends on SQLite.swift:

let indexes = try schema.indexDefinitions("users")

for index in indexes {
    print("\(index.name) columns:\(index.columns))") // <- index.name and index.columns is not visible
}

ObjectDefinition and ColumnDefinition properties are already public, so it seems not to far fetched to change the IndexDefinition properties as well?

The [documentation](https://github.com/stephencelis/SQLite.swift/blob/master/Documentation/Index.md#querying-the-schema)
suggests that the index schema information can be queried. That requires
the `IndexDefinition` properties to be public.
@nathanfallet nathanfallet merged commit 1b1eba0 into stephencelis:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants