New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force try in the `FailableIterator.next()` and `Connection.prepare()` methods #1273

Open

syoung-smallwisdom wants to merge 2 commits into stephencelis:master from syoung-smallwisdom:fix-force-try

syoung-smallwisdom commented Jul 22, 2024

The force try is crashing and ideally, the prepare() query should throw the error rather than crashing the app. Thanks!

Thanks for taking the time to submit a pull request.

Before submitting, please do the following:

Run make lint to check if there are any format errors (install swiftlint first)
Run swift test to see if the tests pass.
Write new tests for new functionality.
Update documentation comments where applicable.

syoung-smallwisdom added 2 commits

July 21, 2024 20:03


          Fix: Do not force try FailableIterator.next()

86eefea


          Fix: Use failableNext() in prepare so that if the try fails it will r…

b1d6806

…ethrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet