Add support for custom SQL aggregates #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfallet
approved these changes
Aug 23, 2021
|
This wasn't quite ready for merging yet. The tests crash intermittently, investigating. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would there be interest in supporting SQLite custom aggregates (and if so, possibly also custom window functions)? This PR adds support for custom aggregates implemented in swift, allowing both a relatively low-level API requiring unsafe pointers to maintain state, as well as a more user-friendly,
reduce-style API. I've attempted to follow the style of the existing code implementing custom SQL functions, and added tests for both API styles.