Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode autodetection #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

NorthIsUp
Copy link
Contributor

@NorthIsUp NorthIsUp commented Feb 4, 2020

Adds detection for system theme and uses the correct icons accordingly.

depends on #117

@steyep
Copy link
Owner

steyep commented Feb 4, 2020

This updates the workflow icons based on your system theme – not your Alfred theme? How does it behave with custom icons added from the settings app? I'll have to check this out but I'm hesitant to add another dependency to this bloated workflow.

@NorthIsUp
Copy link
Contributor Author

not your Alfred theme?

Is there a way to infer dark/light from alfred?

I'll have to check this out but I'm hesitant to add another dependency to this bloated workflow.

Fair, but the current icons are unusable and every update I need to re-install the light color ones, so maybe this is worth it? We could also dive into the library and see how it is doing the detection, if it is simple enough we may be able to just take the function we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants