Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant for Daisy Petal SM #1559

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

beserge
Copy link
Contributor

@beserge beserge commented Nov 23, 2021

This PR fixes/implements the following bugs/features

Add Daisy Petal SM variant
This PR adds the Daisy Petal SM as a variant.

The Petal SM is an upcoming hardware platform from Electrosmith following in the footsteps of the Daisy Seed.

@beserge beserge marked this pull request as draft November 23, 2021 22:16
@fpistm
Copy link
Member

fpistm commented Nov 24, 2021

Hi @beserge
If I well understand you want to add a new board variant Petal but it seems you should first rebase your fork on top of the main branch as the main part of thi RPs include the Patch SM.

@stephenhensley
Copy link

Hi @fpistm

That's correct, since releases don't happen all too often, we figured we'd get the next variant added now in hopes of catching the 2.2.0 release.

We've done a cursory test that works on the prototype hardware, and can do any cleanup early next week.


Do you have a release schedule somewhere (on github, the forum, or elsewhere), or at least an idea of when you're planning on doing the next release?

We will probably have a few more electro-smith/daisy variants to add throughout next year. So having an idea of the release timeline would be helpful for us to work into our scheduling.

Thanks!

@fpistm fpistm added the new variant Add support of new bard label Nov 25, 2021
@fpistm fpistm added this to the 2.2.0 milestone Nov 25, 2021
@fpistm
Copy link
Member

fpistm commented Nov 25, 2021

Do you have a release schedule somewhere (on github, the forum, or elsewhere), or at least an idea of when you're planning on doing the next release?

You can check the milestone.

As you have more and more boards, maybe it would be fine to add a dedicated menu named "ElectroSmith" ?

@beserge
Copy link
Contributor Author

beserge commented Nov 29, 2021

Still TODO: update the readme with the new variant linked to the ES site.

@fpistm fpistm requested a review from ABOSTM November 29, 2021 15:06
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenhensley
Copy link

@fpistm I didn't realize the milestone had a date. That's helpful. Thanks!

And that sounds good. We can move the boards to a single Electrosmith menu next year when we add the new boards we'll be working on.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @beserge

Please, Could you rebase on top of the main?
There is a merge conflict with boards.txt due to the DevEBoxH7 addition.

@fpistm fpistm merged commit 88c6fef into stm32duino:main Dec 2, 2021
@fpistm
Copy link
Member

fpistm commented Feb 28, 2023

Hi @beserge and @stephenhensley
it seems the Daisy Petal SM links does not work anymore and I did not found new one ?
https://www.electro-smith.com/daisy/petal-125b-sm

Could you give me a new link or I simply redirect to https://www.electro-smith.com ?

@stephenhensley
Copy link

Hi @fpistm,

That link is the correct URL. That particular board is still not available for purchase. So the link was disabled on the site.
We'll re-enable the link today, and have it be an appropriate, "Coming Soon" page for the time being.

Thanks for checking.

@fpistm
Copy link
Member

fpistm commented Mar 14, 2023

Hi @stephenhensley
thanks for the update, I will revert the change as the url is now online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants