Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix variant WeActMiniH7xx, DevEBoxH7xx: ena peripheral pll clks #1585

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

ag88
Copy link
Contributor

@ag88 ag88 commented Dec 11, 2021

  • fix variant WeActMiniH7xx: ena peripheral pll clks

in previous commit #1552 some clocks from PLL2, PLL3
are not distributed to some peripherals

originally to save some power. However, users using those
pheriperials may mistake that it is not working

this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz

  • made the same fixes for DevEBoxH7xx

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
    distribute missed out PLL clocks to all peripherals (previously commented out)
  • [ ]

bug fix

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

updated files in installed core and re-ran previous test in original commit.
#1552
compile, Arduino IDE 1.8.16:
Sketch uses 56148 bytes (2%) of program storage space. Maximum is 2097152 bytes.
Global variables use 4112 bytes (0%) of dynamic memory, leaving 520176 bytes for local variables. Maximum is 524288 bytes.

sample results:

p - print/stop print
C - cpu full speed
c - cpu half speed
w - run whetstone
Vref int (1.21v):374
temp sensor:204
mvolt:660
temp:50.00
Beginning Whetstone benchmark at 480 MHz ...

Loops:10000, Iterations:1, Duration:1627.54 millisec
C Converted Single Precision Whetstones:614.42 Mflops
Vref int (1.21v):375
temp sensor:205
mvolt:661
temp:50.50
Vref int (1.21v):376
temp sensor:205
mvolt:659
temp:49.50
Beginning Whetstone benchmark at 480 MHz ...

Loops:10000, Iterations:1, Duration:1627.53 millisec
C Converted Single Precision Whetstones:614.43 Mflops
Vref int (1.21v):374
temp sensor:204
mvolt:660

led blinking per normal

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

ag88 added 4 commits December 12, 2021 02:12
in previous commmit some clocks from PLL2, PLL3
are not distributed to some peripherals
stm32duino#1552

originally to save some power. However, users using those
pheriperials may mistake that it is not working

this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz
in previous commit (stm32duino#1552)
some clocks from PLL2, PLL3 are not distributed to some peripherals

originally to save some power. However, users using those
pheriperials may mistake that it is not working

this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz
make the same fixes from
stm32duino#1585
---
in previous commit (stm32duino#1552)
some clocks from PLL2, PLL3 are not distributed to some peripherals

originally to save some power. However, users using those
pheriperials may mistake that it is not working

this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz
---
@ag88 ag88 changed the title fix variant WeActMiniH7xx: ena peripheral pll clks fix variant WeActMiniH7xx, DevEBoxH7xx: ena peripheral pll clks Dec 11, 2021
@fpistm fpistm added enhancement New feature or request fix 🩹 Bug fix labels Dec 13, 2021
@fpistm fpistm added this to the 2.2.0 🎄 🎅 milestone Dec 13, 2021
@fpistm fpistm merged commit b8e39bc into stm32duino:main Dec 13, 2021
@fpistm
Copy link
Member

fpistm commented Dec 13, 2021

Thanks again @ag88 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants