Interrupts: remove C prototype and keep only C++ prototypes #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
force-pushed
the
INTERRUPTS_REMOVE_C_PROTOTYPES
branch
2 times, most recently
from
029e1d4
to
1fd386b
Compare
ABOSTM
force-pushed
the
INTERRUPTS_REMOVE_C_PROTOTYPES
branch
from
1fd386b
to
fe5a441
Compare
fpistm
requested changes
Jan 6, 2022
attachInterrupt() C prototypes was not usable from C source file (inheritance of former pure C implementation), and causes ambiguity when used with lambda function as callback Fixes stm32duino#1601 Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM
force-pushed
the
INTERRUPTS_REMOVE_C_PROTOTYPES
branch
from
fe5a441
to
c78cb1b
Compare
fpistm
approved these changes
Jan 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interrupts: remove C prototype and keep only C++ prototypes
attachInterrupt() C prototypes was not usable from C source file
(inheritance of former pure C implementation), and causes ambiguity
when used with lambda function as callback
Fixes #1601