Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nucleo-WB15CC #1900

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Added Nucleo-WB15CC #1900

merged 4 commits into from
Jan 9, 2023

Conversation

Subtle-Puneet-Shrivas
Copy link
Contributor

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

Followed the add variant steps for the Nucleo-WB15CC board

Explain the motivation for making this change. What existing problem does the pull request solve?

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

@fpistm fpistm added the new variant Add support of new bard label Jan 3, 2023
@fpistm fpistm added this to the 2.5.0 milestone Jan 3, 2023
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Subtle-Puneet-Shrivas
Thanks for the PR.
Here you add a generic. For Nucleo we need to add dedicated variant_NUCLEO_WB15C to define properly pins ordering and dedicated LED, USER_BTN,...

boards.txt Outdated Show resolved Hide resolved
@fpistm
Copy link
Member

fpistm commented Jan 6, 2023

Hi @Subtle-Puneet-Shrivas
I've rework your PR.
STM32WB is not so easy to add due to linker script and clock config for RF.
I've also fix some issue.

puneet shrivas and others added 4 commits January 6, 2023 10:25
@fpistm
Copy link
Member

fpistm commented Jan 9, 2023

Nucleo WB15CC tested.Note that BLE works with https://github.com/stm32duino/STM32duinoBLE/releases/tag/1.2.2

@fpistm fpistm merged commit ca4beb4 into stm32duino:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants