Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boards.txt for stm32f0discovery (MB1034B) #1913

Closed
wants to merge 1 commit into from

Conversation

devweblab
Copy link

  • Added support for STM32 Discovery board MB1034 B-00
  • Added support for BMP (Generic F0)

Instructions for flashing the BMP (incl. VCP) firmware is here: https://github.com/blackmagic-debug/blackmagic/tree/main/src/platforms/stlink

@fpistm fpistm added the new variant Add support of new bard label Jan 2, 2023
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devweblab
Thanks for the PR.
It seems not valid as not linker script provided.
You declare only the generic no link with the discovery which would require dedicated entry in Discovery menu and dedicated variant files which allows to defined pins ordering and also dedicated LED, user button, system clock....
For the geric it should also be fine to get a generic clock config.
You can also add in the boards.txt the generic F051R8Hx.

@devweblab
Copy link
Author

Hi @fpistm
Ah ok, don't know why it is missing, sorry. It is working with a copy of the linker file from STM32F051R4Tx
https://github.com/stm32duino/Arduino_Core_STM32/blob/main/variants/STM32F0xx/F051R4T/ldscript.ld
Thank you.

@fpistm fpistm added the invalid This doesn't seem right label Jan 18, 2023
@fpistm
Copy link
Member

fpistm commented Jan 18, 2023

PR is not valid and does not correspond to the description. No update since 2 weeks so close it.
Note: BMP upload method should not be added.

@fpistm fpistm closed this Jan 18, 2023
@fpistm fpistm added the wontfix This will not be worked on label Jan 18, 2023
@devweblab
Copy link
Author

Closing this PR is ok, thank you.
Can you please explain me why BMP is not added for F0 boards?
The variant STM32F0xx/F051R8(H-T) is already in you repository. If possible please add the genereic F051R8Tx cpu.

@fpistm fpistm mentioned this pull request Jan 23, 2023
76 tasks
@fpistm
Copy link
Member

fpistm commented Jan 23, 2023

Request added to #722
Yes the folder exists for the variant as we generate all files for all MCU? It still misses a linker script, a generic clock config and to declare it to the boards.txt to declare it.
Generic entries provide 3 default way to flash BMP is specific one, in this case if you want it you should define it on your side using boards.local.txt feature of arduino to override default one: https://arduino.github.io/arduino-cli/0.21/platform-specification/#boardslocaltxt

@devweblab
Copy link
Author

Thank you!
Note: For boards >F0 there is the BMP upload. Example for F1:
https://github.com/stm32duino/Arduino_Core_STM32/blob/main/boards.txt#L2629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right new variant Add support of new bard wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants