map LED_BUILTIN to PA13 #1930
Merged
map LED_BUILTIN to PA13 #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PA13 is the onboard blue LED. Was mapped to PNUM_NOT_DEFINED.
fpistm
approved these changes
Jan 24, 2023
|
@fpistm Just curious, where did you find the schematic? I could only find
the pinout.
…__________________________
Brian Alano
***@***.***
(812) 320-1508
*Green Ellipsis*
Design for the Circular Economy
__________________________
On Tue, Jan 24, 2023 at 3:15 AM Frederic Pillon ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
Looking at the EBB42 V1.1 schematics, PA13 is the status LED of SWDIO.
I guess it is not an issue.
—
Reply to this email directly, view it on GitHub
<#1930 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJO5WEFAO7E2JAEQV6OGPSLWT6FSXANCNFSM6AAAAAAUESZJK4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
duh. looked right past it.
…__________________________
Brian Alano
***@***.***
(812) 320-1508
*Green Ellipsis*
Design for the Circular Economy
__________________________
On Wed, Jan 25, 2023 at 2:25 AM Frederic Pillon ***@***.***> wrote:
https://github.com/bigtreetech/EBB/blob/master/EBB%20CAN%20V1.1%20(STM32G0B1)/EBB42%20CAN%20V1.1/Hardware/BIGTREETECH%20EBB42%20CAN%20V1.1-SCH.pdf
—
Reply to this email directly, view it on GitHub
<#1930 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJO5WEGL7KWQ56TZFTPMFMLWUDIMZANCNFSM6AAAAAAUESZJK4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mapped LED_BUILTIN to PA13, the onboard blue LED. Was mapped to PNUM_NOT_DEFINED.
This PR fixes/implements the following bugs/features
LED_BUILTIN works as expected
motivation
LED_BUILTIN was mapped to PNUM_NOT_DEFINED. Referencing it would not throw a compile-time error, leading to confusion.
Validation
Code formatting
Trival edit
Closing issues
No issues raised (easier to fix than raise an issue).