Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant: NUCLEO-H503RB #2091

Closed
wants to merge 23 commits into from
Closed

Add variant: NUCLEO-H503RB #2091

wants to merge 23 commits into from

Conversation

dojyorin
Copy link
Contributor

@dojyorin dojyorin commented Aug 5, 2023

Add variant: NUCLEO-H503RB

Summary

This PR fixes/implements the following bugs/features

@fpistm feat adds STM32H5 core implementation and NUCLEO-H563ZI support (That was really great help! Thank you!), but variant support is still lacking.

This time, I'll add new H5 NUCLEO board NUCLEO-H503RB with this pull request.
Related to #722 (comment)

Progress

There's still some work to do.

Basically implementation of NUCLEO-H563ZI is used reference.

I'm new to STM32, so excuse me if I'm doing something wrong.
I would like to discuss with everyone and produce good results.

@fpistm
Copy link
Member

fpistm commented Aug 5, 2023

Hi @dojyorin
Thanks for this PR. Anyway 23 commits is too huge to add a board. It should be only 2 commits. 1 for generic and 1 for the nucleo.

@dojyorin
Copy link
Contributor Author

dojyorin commented Aug 5, 2023

Oh I understand. excuse me.
I was a bit confused about how to use pull requests.

Create working branch in my repository, squash merge and resubmit.
I'll close this pull request for now.

@dojyorin dojyorin closed this Aug 5, 2023
@dojyorin dojyorin mentioned this pull request Aug 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants