fix: return 404 if Storipress API return 404 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSnow
reviewed
Jan 29, 2024
| listAll, | ||
| getOne, | ||
| listHash, | ||
| }: DefinePayloadHandlerInput<T>): any { | ||
| return defineSnapshotHandler(async (name, event) => { | ||
| async function handleListAll(bypassCache: boolean): Promise<T[] | KarbonErrorMeta> { | ||
| return await listAll(bypassCache).catch((error: KarbonError | ApolloError) => { | ||
| const networkError = (error as ApolloError)?.networkError as { statusCode: number } |
There was a problem hiding this comment.
❔ 這邊會如何處理 typesense 的 error 呢？
There was a problem hiding this comment.
TypesenseError 也是透過 httpStatus 的屬性來讀取狀態碼的
已經有修正成使用 TypesenseError 的 type
回傳的資料中也有包含原始的 Error 物件提供錯誤判斷
這邊不是直接回傳 Error 是因為如果回傳 Error 物件作為 Response 的話，Nuxt 會無視 setResponseStatus 的設置回傳 500
| export interface KarbonErrorMeta { | ||
| payloadScope?: PayloadScope | ||
| function?: string | ||
| symbol: typeof KarbonErrorSymbol |
There was a problem hiding this comment.
🤔 考量到這邊可能是在 internal.ts export ，也可能在其它地方 export 而導致使用的 symbol 是不同的版本，建議考慮用其它基礎型態來識別 meta ，比如像 Vue 的作法 https://github.com/vuejs/core/blob/d276a4f3e914aaccc291f7b2513e5d978919d0f9/packages/reactivity/src/ref.ts#L382
DanSnow
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://storipress-media.atlassian.net/browse/SPMVP-7009