Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SPMVP-6868] Lazy load subscriber client in karbon #335

Merged
merged 6 commits into from
Feb 28, 2024
Merged

feat: [SPMVP-6868] Lazy load subscriber client in karbon #335

merged 6 commits into from
Feb 28, 2024

Conversation

SidStraw
Copy link
Contributor

@SidStraw SidStraw commented Feb 27, 2024 •
edited by DanSnow
Loading

@SidStraw SidStraw changed the title SPMVP 6868 lazy load subscriber client in karbon feat: [SPMVP-6868] Lazy load subscriber client in karbon Feb 27, 2024
@SidStraw SidStraw force-pushed the SPMVP-6868-lazy-load-subscriber-client-in-karbon branch from 3788e17 to 34cb196 Compare February 27, 2024 02:22
@DanSnow DanSnow self-requested a review February 27, 2024 02:40
DanSnow
DanSnow requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@DanSnow DanSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我用 playground 看 apollo 還是包在 entry chunk ，能確定一下嗎？

image

@SidStraw
Copy link
Contributor Author

SidStraw commented Feb 27, 2024 •
edited
Loading

我用 playground 看 apollo 還是包在 entry chunk ，能確定一下嗎？

@DanSnow 這部分上次有討論過
因為src/runtime/api/track.ts 的部分有 import { gql } from '@apollo/client/core/index.js'
所以還是會有包入 apollo ，但載入的部分已經減少很多，因此這部分目前才維持現狀

@DanSnow DanSnow merged commit 70762e5 into main Feb 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSnow DanSnow DanSnow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SidStraw @DanSnow