-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev setup for React Native #1301
Comments
Thoughts @tmeasday @ndelangen @orta @Gongreg @ajwhite @slorber @ericwooley ? Did I get this all right? |
From a long term perspective, I think yarn workspaces are eventually what you're after - but that's not fully baked yet, so using haul seems like a reasonable answer for right now |
This is an issue worth tracking if your hitting these pain points facebook/metro#1 (comment) |
This issue is also covered by #1286 -- symlinks are similarly a problem for Jest. Still, a solution for RN is great! |
@tmeasday To clarify, are you saying that even if we fix the RN issue, we are still going to have problems with Jest? |
@shilman: correct |
Yea, it's a huge problem. It has to do with node haste. See the issue linked above. Hopefully with yarn workspaces, facebook will have some incentive to fix the issue. It's not easy to solve |
Interesting workaround we could consider: facebook/metro#1 (comment) |
This feels like it's been fixed. |
why
Our dev setup for React Native is messed up right now:
file:
dependencies for RN examples, which copies the directory instead of linking to it. However:file:
links are no longer handled in the same way innpm5
, which creates links instead and is deprecating this type of dependencylerna bootstrap
, which we are using the manage deps for the rest of our projects, which creates links.what
It would be cleaner/simpler to use
lerna bootstrap
across the board. One option is to use thehaul
packager, support for which has been introduced in: #1294NOTE: I have prototyped this on my local machine and verified that it works with
lerna bootstrap
Another option is to revert to
npm@4
and keep our current setup, but this doesn't solve thelerna bootstrap
inconsistency.The text was updated successfully, but these errors were encountered: