-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspaces issue progress #3294
Comments
@bestander @cpojer I was thinking about the |
It could add up to the start time as Yarn would need to find and read multiple package.json files. |
I think this should be fine from a perf-perspective for now. I expect the number of shared projects to be a small number (<100) in most cases. As @bestander said, large projects can also directly embed all the paths. |
Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command. Returns 404 |
Workspaces is not going to be a CLI command but rather a configuration. |
I intend to finish the post by the end of the week.
…On Mon, Jul 17, 2017 at 8:32 PM Rich Burdon ***@***.***> wrote:
Thanks very much @bestander <https://github.com/bestander>
Any idea of the timeline (for the docs, and the features to land?)
Very much looking forward to it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3294 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWBLUb0kiMRl8FDmscPt1SE_alD5Bks5sPCdIgaJpZM4NNLga>
.
|
Should this issue track all workspace related bugs? If yes, I created two issues --
|
Thanks, @donaldpipowitch. BTW, thanks a lot for submitting issues with great repro steps, very much appreciated. |
Thank you for your work ❤ |
Are workspaces still under the experimental flag in the RC? |
Yes, still under experimental
…On Mon, Jul 24, 2017 at 11:07 PM elderfo ***@***.***> wrote:
Are workspaces still under the experimental flag in the RC?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3294 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWHSnlGt_9sz2WgKWVb4016jM6y6Rks5sRYY8gaJpZM4NNLga>
.
|
@bestander any update on your blog or instructions for using workspaces? |
Sorry, I am waiting my colleagues to give feedback on the blogpost, a draft is here yarnpkg/website#580 |
VS code and other tools follow node module resolution as defined here, looking at
Most of the tools follow this semantic that does not allow to access dependencies of siblings packages. What is allowed by hoisting and why it does not play nicely. |
The Node resolution algorithm has no knowledge whatsoever of the Hence why I say: if you want your tools to be aware of the relationships between your packages, then you have to read their |
The |
@svenefftinge How do you think, is it OK to import a second-level dependency directly in your code? Say you have a dependency to
|
Re-exported transitive dependencies are what yarn and npm do by default, so I wouldn't argue that they should not be added. That said, with the design I proposed it would be possible to optionally only link the explicit dependencies. |
Which adds another feature/option that we need to support with increased complexity, that's the point @arcanis is trying to make. It is the toolmakers' responsibility to protect against this one. |
**Summary** Closes #3294 by enabling workspaces by default. **Test plan** Existing tests, slightly modified.
Thank you every on for this great feature. I there an issue where I can track discussion/progress for "nested workspaces"? We used this previously with Lerna and it was a really nice experience. It looked similar to this:
So basically: publishable packages on the first layer and examples for every package at the second layer (with So basically:
|
If anyone is interested, I've added yarn workspaces support to Renovate. It's an open source tool for keeping dependencies and lock files up-to-date which you can run self-hosted (installable via npm/yarn) or via the GitHub App I run, if your repository is on GitHub. |
💡 This seems to work: {
"private": true,
"workspaces": [
"packages/*",
"packages/*/examples/*"
]
} I guess "nested" workspace means multiple |
@bsvipas I think this is |
Thanks everyone, I'll mark this issue as closed. |
…arnpkg#4262) * Update: Enable Workspaces by default but keep the option to turn off **Summary** Closes yarnpkg#3294 by enabling workspaces by default. **Test plan** Existing tests, slightly modified. * Fix bugz * Update install.js
This issue will link all related discussions and RFC.
Prior art (wrappers on top of yarn and npm):
RFC:
link:
:link dependencies rfcs#34, will help when workspaces reference each otherknit
command "yarn knit" -- a command to test libraries while working on them rfcs#41 - simulates publishing a dep instead of just symlinking to a folder. That may be useful for Phase 3 described in workspaces phase 1: aggregated install rfcs#60project:
that is similar toknit
idea Add 'project:' dependencies rfcs#59Pull requests:
project:
proof of concept Add 'project:' dependencies #3281link:
PR feat(type): add support for new link: dependency type #3359Issues/discussions:
lerna
packages – ignore symlinked packages or not found failures #2863 - common node_modules, should be fixed with Phase 1Implementation phase:
The text was updated successfully, but these errors were encountered: