-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable prometheus tendermint metrics #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nourspace With the federated monitoring, am I missing anything?
I've set the typical prometheus annotations for each pod. The pod already has a port mapping to 26660.
The new Prometheus Operator uses resources like You can refer to the cosmos-node-pod-monitor.yaml which I'm adding as part of the sub-monitoring stack deployment. We could also manage that monitor by the operator. I'm using PodMonitor because we don't define a Prometheus service that loadbalances between pods. There is a long discussion on the difference. TLDR from one comment
The end result is the same. The pod endpoints will be the ones scraped and each pod adds its ip as an API reference Labels are no longer supported by the operator |
@nourspace thanks for the detail and background. I'll remove the annotations. The user can customize pod annotations if they want to use this style. |
37b1a88
to
0f6478c
Compare
@nourspace or @agouin This is ready for review again. Small one. |
Closes #19