Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal Smart Gateway #1268

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Conversation

ShadovvBeast
Copy link

A new gateway, support the new version of paypal, dubbed "PayPal Smart".
This is a WIP, but it works for creating orders and charging

@ideadude
Copy link
Member

Thank you for this work. This is great. Can you create a plugin for this vs having us merge into the core plugin? Or with your permission I can create an official repository under the SS org for that.

This will allow us to have people use and test the gateway implementation without potentially affecting core users. We'd also be able to push fixes out more quickly. We'd like to move to a model where add-ons are used for gateways anyway.

Let me know if you'd like to do that (and we can fork it) or if we can create a repo and pull your work into it.

Thanks again.

@ideadude
Copy link
Member

ideadude commented Mar 18, 2020

btw, I would call it pmpro-paypal-smart

Is Smart Payment Buttons the official name of the gateway option?

Smart Connect seems to be something else.

If we think the Smart brand won't move outside buttons, we can call it pmpro-paypal-smart-payment-buttons for completeness.

@ShadovvBeast
Copy link
Author

ShadovvBeast commented Mar 19, 2020 via email

@mircobabini
Copy link
Member

Hey @ShadovvBeast :) Nice work.

What's the difference between Smart Payment Buttons and PayPal Checkout? Just received a newsletter about the last one.

It's very similar to the new PayPal based checkout provided by Presta**op Checkout (don't want to talk about another cms here! 👯 ).

@tictag
Copy link

tictag commented May 15, 2020

I believe PayPal Checkout effectively is Smart Payment Buttons, or rather PayPal Checkout uses Smart Payment Buttons. And PayPal Checkout is essentially the next generation on from PayPal Express, which in turn succeeded PayPal Standard. Basically multiple generations of the "click here and we'll take your money via PayPal's website" concept.

Could be wrong, no expert.

@koditv1235
Copy link

Could you let me know what I might be missing? I uploaded the plugin but it does not show any payment buttons.

@ravisoni6262
Copy link

@ShadovvBeast, does it backward support already created recurring subscription using Paypal express?

@ShadovvBeast
Copy link
Author

@ShadovvBeast, does it backward support already created recurring subscription using Paypal express?

I'm not sure actually, if you find out i'd be glad to hear :)

@mircobabini
Copy link
Member

I think this is not the right question. Since it’s a different gateway, does not need to be compatible with the other one. Old PayPal/PayPal Express orders will still be associated with the old Gateway and new orders will be associated to the new Gateway.

@koditv1235
Copy link

I have it as a separate plugin. How much would you charge to fix it? Whether live production or sandbox, the payments go as sandbox so Live production doesn’t actually process payments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants