Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate email header and footer from "email body" filters #2000

Merged

Conversation

mircobabini
Copy link
Member

@mircobabini mircobabini commented Mar 12, 2022

Ask @mircobabini. Related to #1907.

@mircobabini mircobabini marked this pull request as draft March 12, 2022 05:47
@dparker1005 dparker1005 marked this pull request as ready for review April 8, 2024 15:41
@dparker1005
Copy link
Member

I like the direction that this is going. It makes sense for Add Ons to filter the actual email body (minus headers and footers), and then be able to filter those sections separately. One simplification that we could consider is always running pmpro_kses() on the header and footer. Are there any situations where we don't want that function to run?

@dparker1005 dparker1005 changed the title #1907 alternative (WIP) Separate email header and footer from "email body" filters Apr 8, 2024
@ideadude ideadude added this to the 3.1 milestone Apr 10, 2024
@dparker1005 dparker1005 changed the base branch from dev to v3.1 June 12, 2024 15:19
@dparker1005 dparker1005 merged commit 12d4fbf into strangerstudios:v3.1 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants