Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing expired/cancelled dates for old members in Members List #2908

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixed issue where the expired/cancaellation date would be empty for old members in the Members List.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 changed the title Fixing expired/cancelled dates for old members Fixing expired/cancelled dates for old members in Members List Mar 26, 2024
@ideadude
Copy link
Member

Is this a case where the pmpro_sanitize_with_safelist function could work? How does is that function handled by the Plugin Checker security check now. If we need to sanitize the input or add a comment to negate the scan, we kind of lose the efficiency of using our function. I still like the readability of using our function RE what is happening.

I'd be fine either way. Just wanted to call this out.

https://github.com/strangerstudios/paid-memberships-pro/blob/dev/includes/functions.php#L3668-L3681

@dparker1005 dparker1005 merged commit 02c57bf into strangerstudios:dev Mar 27, 2024
@dparker1005 dparker1005 deleted the memberslist-old-member-date-fix branch March 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants