Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding the PMPro message when switching tabs on the Edit Member page. #2910

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Hiding the PMPro message when switching tabs on the Edit Member page.

Resolves XXX.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude
Copy link
Member

I think we're good, but sometimes we will execute things like pmpro_changeTabs() on page load to make sure the tabs are set up. It doesn't look like we are doing that here, but if we were, we'd basically hide the message on load. I don't know if a comment in the function header would help to stop us from doing something like that later.

Small thing: it seems the tabbing is off in the new code.

@dparker1005 dparker1005 merged commit 6da4529 into strangerstudios:dev Mar 27, 2024
@dparker1005 dparker1005 deleted the hide-edit-user-message-when-switching-tabs branch March 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants