Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing meta boxes added too late or too early #2911

Merged

Conversation

dparker1005
Copy link
Member

@dparker1005 dparker1005 commented Mar 26, 2024

All Submissions:

Changes proposed in this Pull Request:

We have seen plugin conflicts where either our meta boxes aren't being loaded on "edit post" pages with some page builders including Avada, or where add_meta_box() is being called before the function is defined. The latter can cause a fatal error when updating to 3.0.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@ideadude
Copy link
Member

Looks good. Be sure to rebuild blocks and test extensively on the block editor, class editor, and some CPT pages (block and classic editor versions).

@dparker1005 dparker1005 merged commit a119ac5 into strangerstudios:dev Mar 27, 2024
@dparker1005 dparker1005 deleted the post_meta_box_hook_change branch March 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants