Adding setting to enable/disable custom page templates #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arker1005/paid-memberships-pro into enable-page-template-settings
kimcoleman
reviewed
Apr 6, 2024
includes/page-templates.php
Outdated
| ?> | ||
| </p> | ||
| <div class="notice notice-error pmpro_notification pmpro_notification-error"> | ||
| <button type="button" class="pmpro-notice-button notice-dismiss" value="hide_pause_notification"><span class="screen-reader-text"><?php esc_html_e( 'Dismiss this notice.', 'paid-memberships-pro' ); ?></span></button> |
There was a problem hiding this comment.
If we aren't going to allow dismiss in the banner, we should delete this close button.
|
Since this page can get long, we should duplicate the save settings button in all the section boxes. If we don't like that approach, we instead need to move the button outside the last box. |
|
Pushed those changes, thank you! |
…arker1005/paid-memberships-pro into enable-page-template-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Added a setting to the Page Settings page that allows admins to choose to:
By default, this is set to only using custom page templates that have versions that match the core page template versions. This should help to avoid issues where sites update to the newest version of PMPro and functionality on frontend pages breaks as a result.
For sites that are using a theme or 3rd party plugin that includes custom page templates, this can also protect them from authors that do not update their page templates or allow them to avoid using those templates for any other reason.
For sites that have built their own template and are ok being responsible for keeping them up to date, they can choose to always use page templates, regardless of version.
Other information:
Changelog entry